thank-you-2025 #870
Merged
thank-you-2025 #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
thank-you-2025
branch
2 times, most recently
from
e5575df to
60e7d7c
Compare
Abban
force-pushed
the
thank-you-2025
branch
2 times, most recently
from
9611cdb to
4cfe752
Compare
Abban
force-pushed
the
thank-you-2025
branch
7 times, most recently
from
6548553 to
1b508ed
Compare
Abban
force-pushed
the
thank-you-2025
branch
4 times, most recently
from
dea09a3 to
486d6d0
Compare
moiikana
force-pushed
the
thank-you-2025
branch
from
cc6591f to
c01ca2b
Compare
gbirke
force-pushed
the
thank-you-2025
branch
4 times, most recently
from
f2ca4e2 to
e40d25f
Compare
gbirke
approved these changes
Dec 30, 2025
Member
gbirke
left a comment
gbirke
left a comment
There was a problem hiding this comment.
I've rebased this to main and fixed the commits the broke stuff.
| const wrapper = getWrapper(); | ||
|
|
||
| await wrapper.find( '.wmde-banner-full-cta-with' ).trigger( 'click' ); | ||
| const ctaFiveEuroAmount = wrapper.find( '.wmde-b-cta > div:first-child button' ); |
Member
There was a problem hiding this comment.
I like this pattern of naming elements by using a variable (not quite a Page Object but in the same spirit), we should use that more as a team, even if it gives us more of the "naming things" hard problem.
| <CloseButton | ||
| class="wmde-u-sticky" | ||
| :thank-you-content="thankYouContent" | ||
| data-with-background |
Member
There was a problem hiding this comment.
I still think putting in data attributes just to create minor variations that are not due to state (i.e. the data attributes dependent on state) is a mis-application of CUBE CSS.
| @@ -0,0 +1,49 @@ | |||
| <template> | |||
| <details class="wmde-b-disclosure wmde-c-flow wmde-b-prose" :id="id" ref="dialogue" @toggle="onDialogueToggle"> | |||
Member
There was a problem hiding this comment.
This is a really nice example of progressive enhancement/JS and Vue working together
This adds all the required factories, loaders and interfaces for loading the thank you content dynamically. Ticket: https://phabricator.wikimedia.org/T409802
We need to include the content in the live banners using a mediawiki include snippet. This adds it to the build. Ticket: https://phabricator.wikimedia.org/T409802
Delete all the old content components and styles, and update the test imports. Ticket: https://phabricator.wikimedia.org/T409802
Also moves block colour variables into blocks Ticket: https://phabricator.wikimedia.org/T409802
This adds the new dialog attribute that will close the modal when the backdrop is clicked or the esc key is pressed. This is progressive enhancement and not currently supported in all browsers. Ticket: https://phabricator.wikimedia.org/T409802
- Improve mobile text size on mini banner - Improve gaps in footer links - Add better modal close event handling - Modal background is opaque again - Improved progress bar animation - Removed unused modules - Track when dialogues are opened - Updated tests Ticket: https://phabricator.wikimedia.org/T409802
- the text was wrapping differently for the languages, gave them fixed min widths and additional safety margin
This change hides banners via CSS when printing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a new accessible thank you banner with a smashing new design.
Ticket: https://phabricator.wikimedia.org/T408117