remove cpu limits follow up #2057
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So I did some digging from mattermost:
I'm assuming it is not a no-op on charts that set default cpu limits; in this case the null was explicitly unsetting them |
Contributor
Author
|
ahh good catch, in that case we should check the charts first. |
Contributor
|
I looked a bit today and got tempted to clean some up; I think we definitely have issues with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #2050
These are helmfile values only, so should be valid and mostly no-op (apart from staging superset because that value was not
null). As far as I can see there is one limit left for the argo deployed redis but maybe we should touch that outside of this PR, as I'm currently not sure what brought us this ping-ponging back and forth between removing them and reverting again.