check WCMP2 compliance with pywcmp, update to valid centre-ids #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
force-pushed
the
approved-centre-ids
branch
from
84376f2
to
ed95089
Compare
tomkralidis
changed the title
tomkralidis
force-pushed
the
approved-centre-ids
branch
from
ed95089
to
519ce72
Compare
tomkralidis
force-pushed
the
approved-centre-ids
branch
from
519ce72
to
7fae1d0
Compare
| @@ -69,11 +69,11 @@ | |||
| "for dataset in collections['collections']:\n", | |||
| " print(dataset['title'])\n", | |||
| "\n", | |||
| "malawi_obs = oafeat.collection_items('mw-mw_met_centre.data.core.weather.surface-based-observations.synop')\n", | |||
| "malawi_obs = oafeat.collection_items('mw-mw_met_centre-test.data.core.weather.surface-based-observations.synop')\n", | |||
There was a problem hiding this comment.
Not directly related to this PR but please note that all references based on topic-hierarchy-dotpath are incorrect, since the index of the collection is using dataset-id (metadata_id).
There was a problem hiding this comment.
Good catch. I did a sweep across docs, pushed to this PR just now.
|
@tomkralidis topic updates:
|
|
@maaikelimper @david-i-berry this PR is now rebased and ready for review. |
maaikelimper
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates WCMP2 checks in CI to use pywcmp. As well, updates centre id's used in test data to approved/valid identifiers in accordance with WTH (note that Romania and Malawi do not have approved centre-id's, so they are suffixed with
-testper WTH requirements).FYI #739 (when approved) should be merged before this PR, at which point I will rebase.