Skip to content

Update toml cleanup #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 18, 2025
Merged

Update toml cleanup #637

merged 23 commits into from
Apr 18, 2025

Conversation

woelper
Copy link
Owner

@woelper woelper commented Feb 2, 2025

No description provided.

@Stoppedpuma
Copy link
Collaborator

I've done some small rewording to the lossless jpeg transforms section. In the future, how would you feel about just not having this section at all and just applying these lossless jpeg specific versions of the filters if the user selects them like any other format? For example, instead of having the entire lossless jpeg specific dropdown to rotate losslessly, it's instead just works like any other format by selecting the rotate filter in the filters dropdown and behind the scenes switching to use the lossless jpeg transform crop?

@woelper
Copy link
Owner Author

woelper commented Apr 8, 2025

I've done some small rewording to the lossless jpeg transforms section. In the future, how would you feel about just not having this section at all and just applying these lossless jpeg specific versions of the filters if the user selects them like any other format? For example, instead of having the entire lossless jpeg specific dropdown to rotate losslessly, it's instead just works like any other format by selecting the rotate filter in the filters dropdown and behind the scenes switching to use the lossless jpeg transform crop?

I think this would be hard - this depends on the library use flag, so mixing it with another UI is complex. Also operators are non-destructive, which lossless operations are not. They are immediately applied. If you combine them in the edit stack, this would not work any more.

@woelper woelper merged commit e362346 into master Apr 18, 2025
8 checks passed
@woelper woelper deleted the update_toml_cleanup branch April 18, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants