Add tpm2-tools github workflow #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
reviewed
Aug 1, 2025
.github/workflows/tpm2-tools.yml
Outdated
| test/integration/tests/rc_decode test/integration/tests/X509certutil" 2>&1 | tee tpm2-tools-test.log | ||
|
|
||
| # Capture result | ||
| TEST_RESULT=$(grep -q "# FAIL: 2" tpm2-tools-test.log && echo "1" || echo "0") |
There was a problem hiding this comment.
Which test(s) do we expect to fail here? Could you add them as a comment?
But also, should we run the test case if it's going to fail, or is there other value in it?
There was a problem hiding this comment.
These failures only happen with WPFF they don't happen normally. Ill add a comment about which ones fail
There was a problem hiding this comment.
Oh I see. What happens if other tests fail? Would it be more general-purpose to look for just FAIL:?
There was a problem hiding this comment.
I see what you mean let me fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.