Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20250121-deadline-sched-features #69

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

douzzer
Copy link
Collaborator

@douzzer douzzer commented Jan 23, 2025

prepare for release 1.6.3: update ChangeLog.md and doc/wolfSentry_refman.pdf.

update copyright year.

add wolfsentry_set_deadline_rel(), wolfsentry_get_deadline_rel(), and wolfsentry_get_deadline_rel_usecs();

add WOLFSENTRY_SUCCESS_ID_NO_DEADLINE and WOLFSENTRY_SUCCESS_ID_EXPIRED;

add wolfsentry.default_policy, mirroring wolfsentry->routes->default_policy, for lock-free access to default policy;

in wolfsentry_route_event_dispatch_1(), set *action_results to wolfsentry->default_policy before returning error code from failed lock op;

src/wolfsentry_util.c: add helper funcs usecs_to_wolfsentry_time() and wolfsentry_time_to_usecs(), and fix wolfsentry_set_deadline_rel_usecs() to properly convert from usecs to wolfsentry_time_t (which is usecs in built-in time, but can't be relied on);

in src/lwip/packet_filter_glue.c, pivot decision on action_results even on error returns from wolfsentry_route_event_dispatch_with_inited_result(), to honor the default action set upon lock failure (normally TIMED_OUT or BUSY).

add WOLFSENTRY_SUCCESS_ID_NO_WAITING;

fix return codes in wolfsentry_get_thread_deadline();

fix wolfsentry_get_deadline_rel() to handle WOLFSENTRY_DEADLINE_NOW and return positive rel_when when deadline is unexpired;

fix thread->deadline checks in lock functions to handle WOLFSENTRY_DEADLINE_NOW;

add unit tests for wolfsentry_set_deadline_rel(), wolfsentry_set_deadline_rel_usecs(), wolfsentry_get_deadline_rel(), wolfsentry_get_deadline_rel_usecs(), wolfsentry_clear_deadline(), wolfsentry_set_thread_readonly(), and wolfsentry_set_thread_readwrite().

src/json/centijson_sax.c: suppress false positive clang-analyzer-core.NullDereference from clang-20.0.0_pre20250118.

wolfsentry/wolfsentry_util.h: add macro MIN_SINT_OF().

refresh certs in examples/notification-demo/log_server/certs/ and examples/notification-demo/log_server/log_server.c.

refresh lwip patchset at upstream fbd597e450, adding "in *_filter_dispatch_*() implementations, move filter_reason_mask test to start, to minimize overhead."

Makefile.analyzers: in notification-demo-build-test recipe, if log_server launch fails, dump log_server.out before exiting.

tested with make check-all

…mples/notification-demo/log_server/log_server.c.
…patch_*() implementations, move filter_reason_mask test to start, to minimize overhead."
…rver launch fails, dump log_server.out before exiting.
….NullDereference from clang-20.0.0_pre20250118.
… wolfsentry_get_deadline_rel_usecs();

add WOLFSENTRY_SUCCESS_ID_NO_DEADLINE and WOLFSENTRY_SUCCESS_ID_EXPIRED;

add wolfsentry.default_policy, mirroring wolfsentry->routes->default_policy, for lock-free access to default policy;

in wolfsentry_route_event_dispatch_1(), set *action_results to wolfsentry->default_policy before returning error code from failed lock op;

src/wolfsentry_util.c: add helper funcs usecs_to_wolfsentry_time() and wolfsentry_time_to_usecs(), and fix wolfsentry_set_deadline_rel_usecs() to properly convert from usecs to wolfsentry_time_t (which is usecs in built-in time, but can't be relied on);

in src/lwip/packet_filter_glue.c, pivot decision on action_results even on error returns from wolfsentry_route_event_dispatch_with_inited_result(), to honor the default action set upon lock failure (normally TIMED_OUT or BUSY).
fix return codes in wolfsentry_get_thread_deadline();

fix wolfsentry_get_deadline_rel() to handle WOLFSENTRY_DEADLINE_NOW and return positive rel_when when deadline is unexpired;

fix thread->deadline checks in lock functions to handle WOLFSENTRY_DEADLINE_NOW;

add unit tests for wolfsentry_set_deadline_rel(), wolfsentry_set_deadline_rel_usecs(), wolfsentry_get_deadline_rel(), wolfsentry_get_deadline_rel_usecs(), wolfsentry_clear_deadline(), wolfsentry_set_thread_readonly(), and wolfsentry_set_thread_readwrite().
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Even on MacOS all passed:

@dgarske dgarske merged commit 7d8683e into wolfSSL:master Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants