Curve25519: add blinding when using private key #8392
Merged
+410
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
curve25519_blinding
branch
from
ce2aaef to
432bc81
Compare
SparkiDev
force-pushed
the
curve25519_blinding
branch
2 times, most recently
from
7c44a4c to
fb4de99
Compare
|
retest this please |
SparkiDev
force-pushed
the
curve25519_blinding
branch
2 times, most recently
from
62942f5 to
b883da2
Compare
|
retest this please valgrind testing failed with hudson error |
dgarske
previously approved these changes
Feb 12, 2025
There was a problem hiding this comment.
This all looks good and tests out correctly for the larger FE/GE math (without asm).
Do we need to handle the small case too?
./configure --enable-curve25519=small CFLAGS="-DWOLFSSL_CURVE25519_BLINDING" && make
...
CCLD src/libwolfssl.la
Undefined symbols for architecture x86_64:
"_curve25519_blind", referenced from:
_curve25519_smul_blind in src_libwolfssl_la-curve25519.o
ld: symbol(s) not found for architecture x86_64
XOR in random value to scalar and perform special scalar multiplication. Multiply x3 and z3 by random value to randomize co-ordinates. Add new APIs to support passing in an RNG. Old APIs create a new RNG. Only needed for the C implementations that are not small. Modified TLS and OpenSSL compat API implementations to pass in RNG. Fixed tests and benchmark program to pass in RNG.
SparkiDev
force-pushed
the
curve25519_blinding
branch
from
b883da2 to
bb84ebf
Compare
|
Added a compile time check for blinding with options not supporting it. |
dgarske
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XOR in random value to scalar and perform special scalar multiplication.
Fixes zd#19039
Testing
/configure '--disable-shared' '--enable-curve25519' 'CFLAGS=-DWOLFSSL_CURVE25519_BLINDING' '--disable-intelasm' --enable-opensslall
/configure '--disable-shared' '--enable-curve25519=no128bit' 'CFLAGS=-DWOLFSSL_CURVE25519_BLINDING' '--disable-intelasm' --enable-opensslall
Checklist