Skip to content

Coverity fixes for Zendesk issue #9006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

rlm2002
Copy link

@rlm2002 rlm2002 commented Jul 15, 2025

Description

  • Unused values
    • Move res = pt->buffer inside else statement so NULL assignment is not overwritten.
  • Overflowed array index
    • Set check to include any negative value. Function expects only WOLFSSL_FATAL_ERROR to be returned, but adding check in the event another error value can be returned.
  • Logically dead code
    • Remove unused check, mac_alg is always 0 when iteration returns.
    • Add additional check for inLen > 2*ED448_PUB_KEY_SIZE, ensures importing uncompressed public key can be reached. Also reported by wolfSSL Coverity build (CI 299583)
  • Failure to restore non-local value
    • Removes oldLen and sets a->length to 0 if keepOldData is not set. The value of a->length is not changed in other parts of the function, so it is able to be used instead of oldLen when copying oldData into new buffer. wolfSSL Coverity Project CID 315966

Addresses Coverity issues from zd#20212

@rlm2002 rlm2002 self-assigned this Jul 15, 2025
@rlm2002 rlm2002 changed the title Zd20212 Coverity fixes for Zendesk issue Jul 15, 2025
@rlm2002
Copy link
Author

rlm2002 commented Jul 15, 2025

retest this please Jenkins
PRB-fipsv2-regression-and-rolling-release-v3 - Cannot contact wolf-linux-cloud-node-e7fikn: java.io.IOException: cannot find current thread
wolf-linux-cloud-node-d6ugn1 has been removed for 5 min 0 sec; assuming it is not coming back, and terminating shell step. Issue occurs in:
PRB-valgrind-check-v3
PRB-fips-repo-and-harness-test-v3-part1
PRB-multi-test-script
PRB-140-3-tests
PRB-generic-config-parser

@rlm2002
Copy link
Author

rlm2002 commented Jul 16, 2025

retest this please jenkins: PRB-multi-test-script - Found unhandled hudson.remoting.RequestAbortedException exception:
java.io.StreamCorruptedException: invalid stream header: 636F7272

@rlm2002 rlm2002 marked this pull request as ready for review July 16, 2025 15:30
@rlm2002 rlm2002 assigned wolfSSL-Bot and unassigned rlm2002 Jul 16, 2025
@rlm2002 rlm2002 assigned rlm2002 and unassigned wolfSSL-Bot Jul 16, 2025
@rlm2002
Copy link
Author

rlm2002 commented Jul 16, 2025

retest this please Jenkins - PRB-aarch64-tests-v2: Error cloning remote repo 'origin'
Caused by: hudson.plugins.git.GitException: Command "git init /var/lib/jenkins/workspace/PRB-aarch64-tests-v2" returned status code 137

@rlm2002 rlm2002 assigned wolfSSL-Bot and unassigned rlm2002 Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants