Fix undefined variable tls1 in InitSuites for PSK cipher suite#9925
Open
sameehj wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix undefined variable tls1 in InitSuites for PSK cipher suite#9925sameehj wants to merge 1 commit intowolfSSL:masterfrom
sameehj wants to merge 1 commit intowolfSSL:masterfrom
Conversation
The WOLFSSL_OLDTLS_SHA2_CIPHERSUITES else-branch for BUILD_TLS_PSK_WITH_AES_128_CBC_SHA256 referenced undeclared variable `tls1` instead of `tls`, a copy-paste typo from commit a975ba9 (2019). This caused a compilation error when both WOLFSSL_STATIC_PSK and WOLFSSL_OLDTLS_SHA2_CIPHERSUITES were defined. Add PSK CI config with WOLFSSL_OLDTLS_SHA2_CIPHERSUITES to prevent regressions. Signed-off-by: Sameeh Jubran <sameeh@wolfssl.com>
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix undefined variable
tls1inInitSuites()for theBUILD_TLS_PSK_WITH_AES_128_CBC_SHA256cipher suite.The
WOLFSSL_OLDTLS_SHA2_CIPHERSUITES#elsebranch atsrc/internal.c:4253referenced an undeclared variabletls1instead oftls— a copy-paste typo from commit a975ba9 (2019-07-18). This caused a compilation failure when bothWOLFSSL_STATIC_PSKandWOLFSSL_OLDTLS_SHA2_CIPHERSUITESwere defined. In the default build the buggy line was dead code with no impact.Also adds a CI matrix entry in
.github/workflows/psk.ymlto build withWOLFSSL_OLDTLS_SHA2_CIPHERSUITESenabled to prevent regressions.Testing
./configure --enable-psk CFLAGS="-DWOLFSSL_STATIC_PSK -DWOLFSSL_OLDTLS_SHA2_CIPHERSUITES"WOLFSSL_OLDTLS_SHA2_CIPHERSUITESelse-branches inInitSuites()Checklist
.github/workflows/psk.yml)