has_pending_actions_due() performance improvements
#1077
Conversation
barryhughes
requested review from
a team and
coreymckrill
and removed request for
a team
# Conflicts: # classes/abstracts/ActionScheduler_Store.php
There was a problem hiding this comment.
Thanks for the PR @crstauf !
I'm trying to think of the best way to test if has_pending_actions_due() still works as expected with these changes. Any ideas?
At time of creation, does not include 'claimed' => true: unclear if this is appropriate or not.
We discussed this a bit more and decided it's probably better to not include this right now, so this is fine.
@coreymckrill Kinda surprised that there are no unit tests for it, but looking at it, the changes would not impact the result, only the performance. |
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
# Conflicts: # classes/abstracts/ActionScheduler_Store.php
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
There was a problem hiding this comment.
Unit tests added in #1092 are passing here, so calling this good 👍
Closes #1036.
At time of creation, does not include
'claimed' => true: unclear if this is appropriate or not.