Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid including a nodejs library to reduce the index.js bundle size by 42% #1073

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Avoid including a nodejs library to reduce the index.js bundle size by 42% #1073

merged 3 commits into from
Nov 4, 2021

Commits on Nov 2, 2021

  1. Specify the @woocommerce/data version to 1.2.0 to avoid bundling the … 

    …nodejs `crypto` into index.js

Ref
- https://github.com/woocommerce/woocommerce-admin/blob/v1.6.0/packages/data/src/export/utils.js#L4
- woocommerce/woocommerce-admin#5768
    @eason9487
    eason9487 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    37c7ac8 View commit details
    Browse the repository at this point in the history

  2. Rebalance the max size config of bundlewatch to 1.2 times 220.5 kB fo… 

    …r index.js
    @eason9487
    eason9487 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    e5cf5bd View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Add more details for the @woocommerce/data workaround in webpack.co… 

    …nfig.js

Address #1073 (comment)
    @eason9487
    eason9487 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    8a7511b View commit details
    Browse the repository at this point in the history