-
Notifications
You must be signed in to change notification settings - Fork 219
Remove propTypes definitions from Reviews By Product #10249
base: trunk
Are you sure you want to change the base?
Conversation
Please check individual commit as even with |
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hritikchaudhary!
Thanks a lot for your contribution!
By looking at the changes I don't think moving majority of the code from edit.tsx
to block.tsx
file is a good idea. There's a lot of code strictly related to Editor side (e.g. renderEditMode
and whole Inspector Controls implementation).
I recommend to either stick only to removing propTypes
definition or if you want to cleanup the code, split the block definition and Editor related code into block.tsx
and edit.tsx
. 🙏
Also, I’d like you to know that this weekend (8-9 December) WooCommerce Blocks repo will be migrated to WooCommerce monorepo.
However, open PRs won’t be migrated. That means open PRs have to be merged by the end of this week or otherwise, you’ll have to open/recreate a new PR in a monorepo post-migration if you’re interested in finalizing this contribution.
Thanks!
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
Fixes woocommerce/woocommerce#42362
Changes in the PR:
Removed propTypes definitions from Reviews By Product.
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility