This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add Product Collection Full Grid pattern #10665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: enhancement
woocommercebot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
kmanijak
changed the title
|
Size Change: +79 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
kmanijak
changed the title
dinhtungdu
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Thanks for the PR @kmanijak! I have a question and an issue testing this PR:
- From the visual look, the product button is what differs this from Add Product Collection Grid pattern #10660, right? I was confused by the naming. Initially, I thought Full Grid refers to the grid pattern with full width, it turned out a grid with more elements.
- The button alignment didn't work on my test, it's always center regardless of setting. Both my local build and the zip file built for this PR gave me the same result:
I'm following the designs and naming convention from pdnLyh-3uF-p2.
It's funny, after preparing this PR and before you reviewed I changed the wrapper's @dinhtungdu can I ask you for re-review? 🙌 |
dinhtungdu
approved these changes
Aug 28, 2023
samueljseay
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add initial look of Full Grid Product Collection pattern * Refactor textAlign property of Product Button so it uses flex rather than text-align * Update Product Button text align after the fix * Remove debug log (#10719) * Add Product Collection Grid pattern (#10660) * Dispatch the `wc-blocks_render_blocks_frontend` event when rendering the empty cart block (#10619) * E2E: Refactor Mini Cart to be ready for fully parallel (#10704) * Revert dequeue add-to-cart-variation script which is needed to properly handle variable products in single product page (#10723) * Update alignment options to new setting --------- Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Tung Du <[email protected]>
kmanijak
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Product Collection Full Grid pattern.
Additionally, when implementing I realized the Product Button doesn't react on the "Text align" property. Be mindful in this context the initial purpose was to align the whole button (as per #7816) which was preserved in this PR.
Fixes #9369
Why
This is one of the patterns from a set of patterns we'd like to provide for Product Collection
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Known limitations:
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog