This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add to Cart with Options block: Restore the global variable to its original value after being overriden #9581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
May 24, 2023 11:09
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
mikejolley
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested jetpack fix on Jurassic Ninja 👍🏻
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
May 24, 2023
mikejolley
added a commit
that referenced
this pull request
May 24, 2023
tarunvijwani
changed the title
Add to Cart with Options block > Restore the global variable to its original value after being overriden
Add to Cart with Options block: Restore the global variable to its original value after being overriden
Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short-term solution to restore the global product variable to its original value after being overridden within the Add to Cart with Options block. The definitive fix will be shipped on the next upcoming release as part of 9457 and 9494
Ref. p1684924768318569/1684844881.656519-slack-C02UBB1EPEF
Testing
User Facing Testing
Testing with Jetpack
wp-admin/admin.php?page=jetpack_modules
to confirm the WooCommerce Analytics module is enabled.WooCommerce Visibility
Changelog