Skip to content

Add milestone to metadata #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

6543
Copy link
Member

@6543 6543 commented May 13, 2025

closes #3285


Sponsored by Kithara Software GmbH

@xoxys xoxys added feature add new functionality server labels May 14, 2025
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented May 15, 2025

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-5174.surge.sh

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 65.11628% with 15 lines in your changes missing coverage. Please review.

Project coverage is 26.39%. Comparing base (bfe89c8) to head (65bc52a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
server/forge/gitlab/gitlab.go 20.00% 7 Missing and 1 partial ⚠️
server/forge/gitlab/convert.go 50.00% 4 Missing ⚠️
pipeline/frontend/metadata/environment.go 0.00% 1 Missing ⚠️
server/forge/forgejo/helper.go 87.50% 1 Missing ⚠️
server/forge/gitea/helper.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5174      +/-   ##
==========================================
+ Coverage   26.37%   26.39%   +0.02%     
==========================================
  Files         401      401              
  Lines       28536    28558      +22     
==========================================
+ Hits         7525     7538      +13     
- Misses      20322    20331       +9     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543
Copy link
Member Author

6543 commented May 15, 2025

image

@6543
Copy link
Member Author

6543 commented May 19, 2025

done

@qwerty287
Copy link
Contributor

I think it would be nice to get #4626 in first because it simplifies the structure of the pipeline model a lot.

@6543
Copy link
Member Author

6543 commented May 27, 2025

I think it would be nice to get #4626 in first because it simplifies the structure of the pipeline model a lot.

I personally thing that this pr should be merged and I can also resolve the conflicts in #4626 if you want ... because it does not look like the dessision of releaseing a new majour version is not started at all ... else of course it would make sense to wait ?

@xoxys
Copy link
Member

xoxys commented May 27, 2025

Well... please dont rush on this one as well just because you are interested in this particular one.

@6543
Copy link
Member Author

6543 commented May 27, 2025

fair point ;) - as per disclaimer that one is for my dayjob and I can atm run this patch by compiling my version

@6543
Copy link
Member Author

6543 commented May 27, 2025

one thing to clarify would be if the milestone is ok to be exposted as env var at some point or not.
in that case it would be future prove for me to do an API call instead etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buildin Environment variable which hold the milestone
6 participants