hotfix: 좋아요/싫어요 취소 시, 싫어요 취소해도 좋아요 통계 줄어드는 오류 수정 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokodak
approved these changes
Oct 15, 2023
Comment on lines
+124
to
+129
| final Optional<PlaceLike> findPlaceLike = placeLikeRepository.findById(placeLike.getId()); | ||
| final PlaceStatistics findPlaceStatistics = placeStatisticsRepository.findByPlaceId(place.getId()).get(); | ||
| assertSoftly(softAssertions -> { | ||
| assertThat(findPlaceStatistics.getLikeCount()).isEqualTo(beforeLikeCount); | ||
| assertThat(findPlaceLike).isEmpty(); | ||
| }); |
chaewon121
approved these changes
Oct 15, 2023
Comment on lines
+47
to
+51
| private void subtractPlaceLikeCount(final Long placeId, final PlaceLike placeLike) { | ||
| if(placeLike.getType() == PlaceLikeType.LIKE) { | ||
| final SubtractLikeCommand subtractLikeCommand = new SubtractLikeCommand(placeId); | ||
| placeStatisticsService.subtractLike(subtractLikeCommand); | ||
| } |
There was a problem hiding this comment.
저희 enum앞에 클래스명을 붙이지 않는것이 컨밴션이였던것으로 기억합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🛠️ 작업 내용
PR에서 작업한 주요 내용을 적어주세요.
🎯 리뷰 포인트
hotfix입니다.
지난번 좋아요/싫어요 삭제 PR에 대한 수정입니다.
좋아요를 삭제할 때만 좋아요 개수를 한개 줄여야되는데,
싫어요를 삭제할 때도 좋아요 개수를 한개 줄이는 오류 수정입니다.
⏳ 작업 시간
추정 시간: 30분
실제 시간: 15분