feat: 좋아요, 싫어요 버튼을 연속 클릭할 수 없도록 변경 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunji1203
approved these changes
Nov 8, 2023
| } | ||
| } | ||
|
|
||
| private fun singleClick(state: PreferenceState) { |
There was a problem hiding this comment.
해당 singleClick 로직은 훗날 다른곳에서도 사용될 수 있을 것 같아 나중에 공통 로직으로 빼봐도 좋을 것 같아요!
물론 나중에 flow로 변경된다고 하면 이 일회성인 로직이니 굳이 분리할 필요는 없을 것 같긴하네요ㅋㅋ
여기서 한가지 궁금한 점이 있는데, 메서드의 인자로 들어가는 state는 onClick으로 넘겨져서 어떤 일을 하는 건가요?
There was a problem hiding this comment.
preferenceClickListener?.onClick(state)로 전달됩니다.
preferenceClickListener는 PreferenceView에 정의된 인터페이스이며 외부에서 이를 구현하여 setPreferenceClickListener함수를 통해 초기화합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🛠️ 작업 내용
🎯 리뷰 포인트
디바운스를 적용하려 했지만, 코루틴 플로우에 대한 학습이 필요하여 우선 싱글 클릭으로 처리하였습니다.
차후 플로우를(cold) 학습하게 되면 변경할 예정입니다.
⏳ 작업 시간
추정 시간: 2h
실제 시간: 4h
이유: 디바운스를 알아보다가 시간이 오래걸림