Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunji1203
requested changes
Nov 14, 2023
| @@ -102,6 +90,22 @@ class OnAdventureViewModel @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| fun fetchLetters() { | |||
There was a problem hiding this comment.
내위치를 받자마자 딜레이 없이 바로 쪽지를 받아올 수 있도록 수정된 부분이 너무 맘에 드네요👍
| @@ -44,22 +43,11 @@ class OnAdventureViewModel @Inject constructor( | |||
| val isNearby: LiveData<Boolean> = | |||
| myCoordinate.map { adventure.value?.destination?.isNearBy(it) ?: return@map false } | |||
|
|
|||
| private val _lastHint = MutableLiveData<Hint>() | |||
| private var _lastHint = MutableLiveData<Hint>() | |||
There was a problem hiding this comment.
[P3]
val 를 var로 바꾼 이유가 무엇인가요?
There was a problem hiding this comment.
없습니다. 저도 바뀐지 몰랐네욤! 감사합니다!
hyunji1203
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🛠️ 작업 내용
🎯 리뷰 포인트
쪽지 부분을 처음 만져봐서, 혹시 제가 놓친게 있는지 봐주시면 감사하겠습니다.
이번 이슈와 관계 없이 폴링 로직을 변경했는데 확인 한 번 부탁드립니다.
⏳ 작업 시간
추정 시간: 1h
실제 시간: 3h
이유: 폴링 로직을 다른 방식으로 변경하려고 도전해보다가 시간이 오래 걸렸습니다.