refactor: 도메인 재설계 #366
Closed
refactor: 도메인 재설계 #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonyongChoi05
requested review from
iamjooon2,
parkmuhyeun and
kyY00n
as code owners
wonyongChoi05
force-pushed
the
refactor/#364
branch
from
f1df636 to
b136096
Compare
wonyongChoi05
requested review from
kyY00n,
iamjooon2 and
parkmuhyeun
and removed request for
kyY00n,
iamjooon2 and
parkmuhyeun
parkmuhyeun
reviewed
Aug 31, 2023
| } | ||
|
|
||
| private BooleanExpression isContainFunctionalities(List<String> functionalityList) { | ||
| if (functionalityList.isEmpty()) { | ||
| private static BooleanExpression isContainPrimaryIngredients(List<String> primaryIngredientList) { |
| @OneToMany(mappedBy = "petFood", cascade = {CascadeType.PERSIST, REMOVE}) | ||
| private List<PetFoodFunctionality> petFoodFunctionalities = new ArrayList<>(); | ||
| @OneToMany(mappedBy = "petFood", orphanRemoval = true, cascade = {PERSIST, REMOVE}) | ||
| private List<PetFoodEffect> petFoodEffects = new ArrayList<>(); |
There was a problem hiding this comment.
일단 다 보긴했는디
요거를 짚고가야 아래꺼 추가적으로 리뷰를 할 수 있을듯용
지금 바뀐게
Functionality(기능) 하고 PrimaryIngredient(주원료)가 PetFoodEffect 하나의 엔티티로 바뀌고 컬럼한개로 구분하는거 같슴다.
근데 전 두 개가 다른 카테고리 같아서 묶는 건 조금 어색하다고 생각합니당.
그리고 후에 기능이든 주원료든 추가되는 컬럼이 있으면 공통으로 쓸 수 없을텐데 혹시 이렇게 설계하신 이유가 있을까용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More