Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 이스터에그 토스트 사용성 개선 및 hook 디렉토리 이동 #527

Merged
merged 4 commits into from
Oct 20, 2023
Merged

refactor: 이스터에그 토스트 사용성 개선 및 hook 디렉토리 이동 #527

merged 4 commits into from
Oct 20, 2023

Conversation

n0eyes
Copy link
Collaborator

@n0eyes n0eyes commented Oct 20, 2023

📄 Summary

  • 다른 페이지로 이동 시 렌더링중인 토스트를 제거
  • 토스트 발생 높이를 재조정
  • 이스터에그 배너 컴포넌트 및 훅 분리
  • hooks/common > hooks/@common으로 전부 이동

🙋🏻 More

@n0eyes n0eyes self-assigned this Oct 20, 2023
@n0eyes n0eyes merged commit ef95a6f into develop Oct 20, 2023
1 check passed
@n0eyes n0eyes deleted the refactor/#526 branch October 20, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonyongChoi05 wonyongChoi05 wonyongChoi05 approved these changes

@ksone02 ksone02 ksone02 approved these changes

@HyeryongChoi HyeryongChoi Awaiting requested review from HyeryongChoi HyeryongChoi is a code owner

Assignees

@n0eyes n0eyes

Labels
📚 Frontend 🔨 Refactor
Projects
2023-zipgo
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] 이스터에그 토스트 개선
3 participants
@n0eyes @ksone02 @wonyongChoi05