[FE] github actions 으로 cd 를 구축한다. #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooherin
temporarily deployed
to
frontend-development
GitHub Actions
Inactive
ooherin
had a problem deploying
to
frontend-development
GitHub Actions
Error
ooherin
temporarily deployed
to
frontend-development
GitHub Actions
Inactive
healim01
reviewed
Dec 4, 2024
| echo "API_URL=${{ secrets.API_URL }}" | ||
| echo "REDIRECT_URI=${{ secrets.REDIRECT_URI }}" | ||
| echo "CLIENT_ID=${{ secrets.CLIENT_ID }}" | ||
| echo "GA_ID=${{ secrets.GA_ID }}" |
There was a problem hiding this comment.
필요없는 것 같아서 해당 코드를 다 지웠습니다! env 에서 제외시켜도 될 것 같아요
healim01
reviewed
Dec 4, 2024
| @@ -27,7 +27,7 @@ const S = { | |||
| display: flex; | |||
| justify-content: center; | |||
| align-items: center; | |||
| height: 100vh; /* 전체 화면 높이에 맞춰 정렬 */ | |||
| height: 100vh; | |||
ooherin
temporarily deployed
to
frontend-development
GitHub Actions
Inactive
ooherin
temporarily deployed
to
frontend-development
GitHub Actions
Inactive
|
수고하셨습니다 |
skiende74
reviewed
Dec 4, 2024
Comment on lines
39
to
46
| - name: Install Dependencies | ||
| working-directory: ./frontend | ||
| run: npm install | ||
|
|
||
| - name: Build for Dev | ||
| working-directory: ./frontend | ||
| run: npm run build:dev-fe | ||
|
|
There was a problem hiding this comment.
프로젝트나 기존 yml 파일들도 모두 yarn인 만큼 npm말고 yarn으로 통일하는 게 좋을거같습니다!
CI 시간단축에도 도움이 되고요
yarn을 쓰려면 node버전이 16.10이상이어야해서 node-version: 18.x을 해두시면 될 거 같네요.
There was a problem hiding this comment.
와 이부분은 빠트렸네요!! 역시 제이드입니다 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
github actions 을 통한 cd 구축
github actiosn의 env 관리
불필요한 env 제거
📢 논의하고 싶은 내용
🎸 기타