[BE] 체크리스트 지하철 정보 저장 시 위도, 경도가 NULL 인 경우도 허용한다. #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JINU-CHANG
reviewed
Dec 9, 2024
JINU-CHANG
reviewed
Dec 10, 2024
Comment on lines
+42
to
+44
| if (latitude == null || longitude == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
수정 API에서는 여기서 null로 저장되어야하지 않을까요?? 지금은 그냥 return되고 있어 수정사항이 반영되지 않을 것 같아요!
There was a problem hiding this comment.
확인해봤는데 체크리스트 수정할 때 updateChecklistByIdV1 메서드에서 이미 room 정보를 통째로 수정해서 위도, 경도가 변경된 값으로 초기화 되더라고요! 그래서 처리하지 않아도 될 것 같습니다!
There was a problem hiding this comment.
room 정보말고 지하철 정보를 말한 거였어요! checklist_station은 그대로이지 않나요 🤔
There was a problem hiding this comment.
checklistStation도 다시 새로운 지하철 정보 저장하기 전에 32번째 줄에 checklistStationRepository.deleteAllByChecklistId(checklist.getId()) 호출해 초기화해줘서
새로운 지하철 정보로 바뀌어서 문제 없을 것 같습니다!
There was a problem hiding this comment.
테스트 결과를 잘못보고 있엇네요,,ㅎㅎ 고생하셨습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타