-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: 안드로이드 멀티모듈화 #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chaehyuns
wants to merge
22
commits into
chongdae
Choose a base branch
from
feature/768-multi-module
base: chongdae
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
close #768
✨ 작업 내용
대략적인 멀티모듈의 설계도는 아래의 그림과 같습니다.

여기서 :domain 모듈과 :core :common 모듈은 순수 kotlin 모듈입니다.
feature 별로의 모듈 분리를 할지 말지 고민이 되지만, 이 부분은 안드 팀 모두 회의 후 결정하면 좋을 것 같숩니다~
📚 기타
하는김에 각 기능별로 패키지 분리도 진행
서기 파트 코드 변경 부분
offering에서 refresh token 로직 삭제
이미지 업로드
domain을 순수 kotlin으로 만들기 위해 이미지 업로드 multipart 부분 변경 2a4b4bc