Skip to content

fix: 공고수정시 수정하기 버튼 비활성화 버튼 수정 #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

lurgi
Copy link
Contributor

@lurgi lurgi commented Feb 16, 2025

작업 내용

  • 공고수정시 수정하기 버튼 비활성화 버튼 수정

참고 사항

  • KUCC 측에서 단일 Choice를 사용한 것으로 확인, 이에따라 valid 로직을 수정합니다.

@lurgi lurgi requested a review from llqqssttyy February 16, 2025 12:40
Copy link
Contributor

1739709668.546619

@lurgi lurgi self-assigned this Feb 16, 2025
@lurgi lurgi added the fix 버그 수정 label Feb 16, 2025
Comment on lines +39 to +46
applyState.slice(DEFAULT_QUESTIONS.length).every((question) => {
const isQuestion = question.question.trim();
if (!(question.type === 'MULTIPLE_CHOICE' || question.type === 'SINGLE_CHOICE')) {
return isQuestion;
}
const isChoice = question.choices.some((choice) => choice.choice);
return isQuestion && isChoice;
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@lurgi lurgi merged commit 87c1b0f into fe/main Feb 16, 2025
14 of 15 checks passed
@lurgi lurgi deleted the fix-apply-valid branch February 16, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

2 participants