fix: 공고 수정시 발생한 버그에 따른 질문 key값 수정 #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1739779664.155759 |
llqqssttyy
requested changes
Feb 17, 2025
| @@ -49,20 +49,20 @@ function getQuestions(data: QuestionData[] | undefined): Question[] { | |||
| export default function useApplyManagement({ applyFormId }: UseApplyManagementProps): UseApplyManagementReturn { | |||
| const { data, isLoading } = applyQueries.useGetApplyForm({ applyFormId: applyFormId ?? '' }); | |||
| const [applyState, setApplyState] = useState(getQuestions(data)); | |||
| const [uniqueId, setUniqueId] = useState(DEFAULT_QUESTIONS.length); | |||
| const [uniqueId, setUniqueId] = useState(applyState[applyState.length - 1]?.id || DEFAULT_QUESTIONS.length); | |||
There was a problem hiding this comment.
기존에 존재하던 질문이면 해당 아이디를 사용하고, 아니라면 length를 id로 만들게 되네요.
이렇게 되면 기존에 있던 질문의 id와 length가 일치할 경우 key 값이 중복되는 문제가 발생해요.ㅠㅠ
새롭게 생성된 질문의 id는 ${applyState[applyState.length-1]?.id}-added와 같이 특별한 문자열을 넣거나, 현재 시각의 밀리초를 해시값처럼 붙이는 방법을 사용해야 할 것 같습니다. 어떤 방법이 나을지 고민해 보시고 반영해주세요!
There was a problem hiding this comment.
요고 id값에 1만 더해주면 될 것 같아 보이는데 어떻게 생각하세용? 증가값이라 중복 없을 것 같아요!
There was a problem hiding this comment.
일단 오늘 까지 리팩터링해서 올려볼게용
There was a problem hiding this comment.
아하 기존공고가 문제가되는군요! 수정했슴니당~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용