[Feature] - 여행기 및 여행 계획 상세페이지 접근성 개선 #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results11 tests 11 ✅ 14s ⏱️ Results for commit e0fc8b1. ♻️ This comment has been updated with latest results. |
0jenn0
approved these changes
Oct 23, 2024
| const handleCloseDeleteModal = () => { | ||
| handleCloseMoreDropdown(); | ||
| setIsDeleteModalOpen(false); | ||
| setDeleteModalAnnouncement("삭제 창이 닫쳤습니다."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
📸 스크린샷
2024-10-23.12PM.mov
2024-10-23.12.36PM.mov
🙈 참고 사항
작업 완료했습니다
체크박스 label 부분이 약간 아쉬운 거 같기도 해서 얘를 개선해볼까싶기도 합니다! 일단 접근성 둘다 90점 넘어서 괜찮은 거 같습니다