Skip to content

feat: SpokeVoteAggregator and WormholeDispatcher expanded testing #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 9, 2024

Conversation

marcomariscal
Copy link
Collaborator

@marcomariscal marcomariscal commented Jun 26, 2024

Expands the tests for SpokeVoteAggregator and implements tests for WormholeDispatcher.

Includes an update to the WormholeDispatcher contract: the ConsistencyLevelUpdated event is emitted before the state update.

@marcomariscal marcomariscal changed the title feat: SpokeVoteAggregator and WormholeDispatcher expaned testing feat: SpokeVoteAggregator and WormholeDispatcher expanded testing Jun 26, 2024
@marcomariscal marcomariscal force-pushed the feat/spoke-vote-agg-and-whole-dispatcher-testing branch from 858beee to 93f6cae Compare June 26, 2024 21:04
@marcomariscal marcomariscal linked an issue Jun 26, 2024 that may be closed by this pull request
@marcomariscal marcomariscal marked this pull request as ready for review June 26, 2024 22:01
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, 97% coverage is great!

Copy link

Coverage after merging feat/spoke-vote-agg-and-whole-dispatcher-testing into main will be

97.49%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   HubGovernor.sol93.55%100%87.50%93.75%138, 91
   HubMessageDispatcher.sol100%100%100%100%
   HubProposalMetadata.sol0%100%0%0%10, 14–15
   HubVotePool.sol100%100%100%100%
   SpokeAirlock.sol100%100%100%100%
   SpokeMessageExecutor.sol95.56%85.71%100%100%43, 61
   SpokeMetadataCollector.sol100%100%100%100%
   SpokeVoteAggregator.sol100%100%100%100%
   WormholeDispatcher.sol100%100%100%100%
src/extensions
   GovernorSettableFixedQuorum.sol100%100%100%100%
src/lib
   SpokeCountingFractional.sol100%100%100%100%

@marcomariscal marcomariscal force-pushed the feat/spoke-vote-agg-and-whole-dispatcher-testing branch from a46105f to 7cdbb21 Compare July 5, 2024 16:55
alexkeating
alexkeating previously approved these changes Jul 8, 2024
@alexkeating alexkeating merged commit 51b16fd into main Jul 9, 2024
4 checks passed
marcomariscal added a commit that referenced this pull request Dec 9, 2024
…#77)

* Expand testing

---------

Co-authored-by: Alexander Keating <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round out testing for SpokeVoteAggregator and WormholeDispatcher
2 participants