Skip to content

feat: CrosschainAggregateProposer #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 79 commits into from
Jul 26, 2024
Merged

feat: CrosschainAggregateProposer #86

merged 79 commits into from
Jul 26, 2024

Conversation

marcomariscal
Copy link
Collaborator

@marcomariscal marcomariscal commented Jul 11, 2024

Description

Includes the CrosschainAggregateProposer contract to check for proposal eligibility by tallying up all cross-chain vote weight, including the hub, for the caller. This contract will be the whitelisted proposer on the HubGovernor.

Also includes changes from #89, which are necessary here for the HubProposalPool to query the SpokeVoteAggregator getVotes func.

Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial thoughts on this wip pr

@marcomariscal marcomariscal force-pushed the feat/hub-proposal-pool branch 2 times, most recently from b0ec4ae to 595e9ed Compare July 23, 2024 17:06
@marcomariscal marcomariscal changed the base branch from main to fix/spoke-vote-aggregator-get-votes July 23, 2024 17:08
@marcomariscal marcomariscal changed the base branch from fix/spoke-vote-aggregator-get-votes to main July 23, 2024 17:08
@marcomariscal marcomariscal marked this pull request as ready for review July 23, 2024 18:06
@marcomariscal marcomariscal changed the title feat: HubProposalPool wip feat: HubProposalPool Jul 23, 2024
@marcomariscal marcomariscal force-pushed the feat/hub-proposal-pool branch from 92bcb28 to aa5cee8 Compare July 24, 2024 16:51
@marcomariscal marcomariscal changed the title feat: HubProposalPool feat: CrosschainAggregateProposer Jul 25, 2024
@alexkeating alexkeating merged commit ae76962 into main Jul 26, 2024
4 checks passed
marcomariscal added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants