Skip to content

Update INttToken.sol #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

Update INttToken.sol #653

merged 2 commits into from
Jul 18, 2025

Conversation

nik-suri
Copy link
Collaborator

Clarify that setMinter is not a required function for integration with NTT.

@nik-suri nik-suri requested review from dvgui and evgeniko July 14, 2025 21:38
evgeniko
evgeniko previously approved these changes Jul 15, 2025
Copy link

@dvgui dvgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions:

  • The mint function is actually required for all spoke chain tokens, as well as for tokens operating in burn-and-mint manager mode. It is only not required for hub-and-spoke manager chain tokens and for the hub itself. Clarifying this in the comments would help avoid confusion for integrators.

  • For setMinter, I agree it’s not required and should be presented as optional or removed. There are multiple legitimate ways to implement minter management, such as using role-based access control or other custom approaches, not just a single setter. It might be helpful to mention these alternatives in the comment to encourage flexibility for implementers.

// NOTE: The `setMinter` method is not present in the standard ERC20 interface.
//       This is an optional function for integration with NTT. There are multiple ways to manage token minters (e.g., role-based access control, custom implementations).
//       Providing flexibility to change or assign multiple minters is recommended, but the exact mechanism can vary.

@nik-suri
Copy link
Collaborator Author

Thanks @dvgui! I agree and I've updated both comments based on your feedback above.

nik-suri added 2 commits July 18, 2025 00:52
Clarify that `setMinter` is not a required function for integration with NTT.
@nik-suri nik-suri merged commit 4554c2e into main Jul 18, 2025
9 checks passed
@nik-suri nik-suri deleted the nik-suri-patch-1 branch July 18, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants