Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2.3.0 #200

Merged
merged 34 commits into from
Apr 24, 2024
Merged

release: v2.3.0 #200

merged 34 commits into from
Apr 24, 2024

Conversation

jasonbahl
Copy link
Contributor

Release Notes

Update Notice

This release refactored some internals regarding how Clone fields and Group fields behave. There was no intentional breaking changes to the Schema, but if you are using Clone and Group fields there is a chance that if you were benefiting from a "bug as a feature" there might be some changes that could impact your Schema and/or resolvers, we recommend testing this update on a staging site to ensure things are still working for you as expected. Should you run into any problems, please open a new issue and provide as much detail as possible to help us reproduce the scenario. Thanks! 🙏

New Features

  • #193: feat: improved handling of clone and group fields

Chores / Bugfixes

  • #194: ci: test against WordPress 6.5

…roblem. . .but gets us heading in the right direction
…d to a field group

- update CloneField.php to return 'NULL' type as the registry handles getting the interfaces now
- update Group.php field type to return the Cloned Type if possible instead of registering a new Type
- update plugin header to match the readme.txt
- update testing workflow to test against WordPress 6.5
…to the AJAX function. Instead of sending the entire form, only send fields required to determine location rules

- modify the ajax callback to compensate for the modified ajax request in main.js
…tion

- fix call to possibly unset `$parent_field_group['ID']`
- phpstan fixes
- update acf_get_raw_fields to acf_get_fields
- add adjustments to how group types are registered if they've been cloned
@jasonbahl jasonbahl added the release Pull request intended for a release label Apr 24, 2024
@jasonbahl jasonbahl self-assigned this Apr 24, 2024
@coveralls
Copy link

coveralls commented Apr 24, 2024

Pull Request Test Coverage Report for Build 698d23b2c0ff95af3156a042736942d0edda00d7-PR-200

Details

  • 30 of 86 (34.88%) changed or added relevant lines in 7 files are covered.
  • 23 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.0%) to 62.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/FieldType/FlexibleContent.php 0 1 0.0%
src/FieldConfig.php 2 4 50.0%
src/FieldType/CloneField.php 2 6 33.33%
src/Registry.php 20 24 83.33%
src/Admin/Settings.php 0 11 0.0%
src/FieldType/Repeater.php 3 14 21.43%
src/FieldType/Group.php 3 26 11.54%
Files with Coverage Reduction New Missed Lines %
src/Admin/Settings.php 1 0.0%
src/ThirdParty/AcfExtended/AcfExtended.php 1 89.1%
src/FieldType/CloneField.php 21 26.67%
Totals Coverage Status
Change from base Build 153761c13facee4bfb5e7c2c7d59a7b58ca2117b: -1.0%
Covered Lines: 2091
Relevant Lines: 3336

💛 - Coveralls

@jasonbahl jasonbahl merged commit 5c2b464 into main Apr 24, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull request intended for a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants