fix: replace filter_input with sanitize_text_field#72
Closed
jasonbahl wants to merge 1 commit intowp-graphql:mainfrom
Closed
fix: replace filter_input with sanitize_text_field#72jasonbahl wants to merge 1 commit intowp-graphql:mainfrom
filter_input with sanitize_text_field#72jasonbahl wants to merge 1 commit intowp-graphql:mainfrom
Conversation
Contributor
Author
|
Closing PR as tests fail when a PR is opened from a fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This replaces the
filter_inputfunction withsanitize_text_fieldwhen verifying the nonce for checking Admin Location Rules when ACF Field Group pages are loaded or various settings of the field group are modified.The
FILTER_SANITIZE_STRINGargument was deprecated in php 8.1Does this close any currently open issues?
closes #69
Any other comments?
With ACF Pro v6.1.7, WPGraphQL 1.14.9 and WPGraphQL for ACF (v2.0.0-beta.3.1.0) active, when opening the admin page for an ACF Field Group:
Before
The following error message would be displayed in the console in response to the AJAX method to check the graphql location rules:
After
The error message is no longer returned: