Skip to content

Conversation

@Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Dec 15, 2025

Description

Fixes #7556
Temporary PR to change version to dev-branch of plugin-family repo to confirm fix.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

What was tested

Refer to wp-media/plugin-family#31

How to test

Refer to wp-media/plugin-family#31

Affected Features & Quality Assurance Scope

Refer to wp-media/plugin-family#31

Technical description

Documentation

Refer to wp-media/plugin-family#31

New dependencies

Refer to wp-media/plugin-family#31

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld requested a review from a team December 15, 2025 01:46
@Miraeld Miraeld self-assigned this Dec 15, 2025
Copilot AI review requested due to automatic review settings December 15, 2025 01:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is a temporary testing PR that updates the wp-media/plugin-family dependency from stable version 1.0.6 to a development branch dev-enhancement/7556-add-filter-banner-imagify to verify a fix in the upstream repository before it's officially released.

Key Points:

  • Changes composer dependency to point to a feature branch for testing purposes
  • The dev branch is related to adding a filter for Imagify banner functionality
  • This change allows testing the fix locally before the plugin-family library releases an official version

@codacy-production
Copy link

codacy-production bot commented Dec 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9e90f2b1 53.13% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9e90f2b) Report Missing Report Missing Report Missing
Head commit (d72ce2e) 41902 18901 45.11%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7956) 32 17 53.13%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a filter to control Imagify banner on Media gallery components

3 participants