Ui modernization #772
Open
Ui modernization #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobody5050
force-pushed
the
ui-improvements-2-electric-boogaloo
branch
7 times, most recently
from
2e89356 to
d6dd638
Compare
nobody5050
force-pushed
the
ui-improvements-2-electric-boogaloo
branch
from
d6dd638 to
30d1cca
Compare
Closed
* Remove simple pathUtils functions * Remove unused deps * Fix extension build * Delete unused stuff, do formatting touch ups * Fold wpilibapi into extension and remove shims * Move i18n to l10n and fix API imports * Remove unneeded project generator code * Fix 2025 stuff * Fix CSS
* Move catch block * Remove Command Palette vendordep manager * Make webpack configs work properly * Fix up help page layout * Fix icon * Remove unnecessary .then() * Format
…ation link on help page to 2027
* Clean up utilities * Inline file processor * Format
|
This looks to be doing multiple things, which makes it really hard to review. It looks like there's refactoring that's enabled by #767, which should probably be a separate PR, so that the actual UI changes are more easily reviewable. Also, it would really help for the PR to describe how the UI is improved. A picture is worth a thousand words. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23