Ui modernization #772
Ui modernization #772
Conversation
nobody5050
force-pushed
the
ui-improvements-2-electric-boogaloo
branch
7 times, most recently
from
2e89356 to
d6dd638
Compare
nobody5050
force-pushed
the
ui-improvements-2-electric-boogaloo
branch
from
d6dd638 to
30d1cca
Compare
* Remove simple pathUtils functions * Remove unused deps * Fix extension build * Delete unused stuff, do formatting touch ups * Fold wpilibapi into extension and remove shims * Move i18n to l10n and fix API imports * Remove unneeded project generator code * Fix 2025 stuff * Fix CSS
* Move catch block * Remove Command Palette vendordep manager * Make webpack configs work properly * Fix up help page layout * Fix icon * Remove unnecessary .then() * Format
…ation link on help page to 2027
* Clean up utilities * Inline file processor * Format
|
This looks to be doing multiple things, which makes it really hard to review. It looks like there's refactoring that's enabled by #767, which should probably be a separate PR, so that the actual UI changes are more easily reviewable. Also, it would really help for the PR to describe how the UI is improved. A picture is worth a thousand words. |
* Move dependencyView back to its original location * Move files back * Move locale file back
|
We moved several files back to their original locations to help minimize the diff. The API package folding and new utility files were not undone, solely because this originated as an deep refactoring of many dark corners of the codebase, and the changes are a little too intertwined to safely undo. This branch has already been shredded apart and reconstituted multiple times to get it in a state even remotely close to review. The codebase is fundmentally under too much tech debt to be able to do smaller incremental refactors, and we have several deeper refactors queued up that are blocked on the changes in this PR. The diff on just the TypeScript files is now +2975 lines, -1769 lines, split between modernizing the UI (the majority) and refactoring file handling for project generation and file templates. We apologize for the large diff, but hope that the PR is still reviewable enough that reviewed and merged. If it helps with reviewing, everything in shared and the commands.ts files for both C++ and Java, except for the vendor files in shared are the files that were changed because of the file handling refactor. Everything else is either minor changes like imports or typo fixes, or it's UI modernization. |
Absolutely! Starting small, this PR adds an "install from url" section to the vendor dependencies UI that was added in 2025. In adding this, the command palette vendordep manager is officially removed as it is no longer needed for anything. Also, it revamps the RioLog UI to be cleaner, use VSCode UI elements and styling (including the user's VSCode theme) and adding ANSI escape sequence support so that the color of log entries can be set as they would in a normal terminal. It also adds a default "welcome" message when initialized. The WPILib Help page has been updated and now includes some basic getting started tasks and a button that opens the command palette. The project creation page has been updated to be paginated, make use of the user's VSCode theme and also make use of VSCode's inbuilt UI elements. And lastly the project importer has also been updated to follow a similar design language If there's anything else you'd like to know, I (or @Gold856) would be happy to answer! |
| </label> | ||
| </div> | ||
| <div id="xrpRomiError" class="project-error-text"> | ||
| You cannot select both Romi and XRP |
There was a problem hiding this comment.
I'd make these radio buttons instead of checkboxes if they're meant to be mutually exclusive?
There was a problem hiding this comment.
Checkboxes is just retaining behavior from the previous UI. I suppose it's up to the reviewer if that's something we should change.
There was a problem hiding this comment.
Ideally they'd go away and the importer would detect them automatically #528
radio buttons are probably the more logical UI choice with the default being import for Systemcore. But wouldn't hold this up since it's existing behavior.
| </div> | ||
| <div class="radio-option"> | ||
| <input id="noneCB" type="radio" name="hardware" value="none" checked /> | ||
| <label for="noneCB">roboRIO</label> |
There was a problem hiding this comment.
Since this is targeted to 2027, this should be Systemcore.
There was a problem hiding this comment.
Any chance we could get some of these ui changes in 2026? For instance, riolog is still named riolog in this pr
closes #23