Skip to content

Merge pull request #327 from wpmudev/new/segmented-button #1219

Merge pull request #327 from wpmudev/new/segmented-button

Merge pull request #327 from wpmudev/new/segmented-button #1219

Triggered via push September 18, 2024 06:05
Status Success
Total duration 2m 34s
Artifacts

code-review.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

3 warnings
code-quality
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
code-quality: packages/ui/modal/src/modal.tsx#L72
React Hook useCallback has a missing dependency: 'onCloseModal'. Either include it or remove the dependency array. If 'onCloseModal' changes too often, find the parent component that defines it and wrap that definition in useCallback
code-quality: packages/ui/uploader/src/uploader-file.tsx#L33
React Hook useEffect has a missing dependency: 'file'. Either include it or remove the dependency array. If 'setPreviewUrl' needs the current value of 'file', you can also switch to useReducer instead of useState and read 'file' in the reducer