Port subset of em_real tests from regression tests#2215
Closed
Port subset of em_real tests from regression tests#2215
Conversation
This script is based on the very well-named script.csh out of the also very well-named repo : https://github.com/wrf-model/SCRIPTS While it runs the rd_l2_norm.py, if not present it does not error out. Instead diffwrf is used as that is more precise in its comparisons.
These tests are based on : https://github.com/kkeene44/wrf-coop/blob/version16_update/build.csh
Collaborator
|
The regression test results: |
islas
commented
May 1, 2025
|
|
||
|
|
||
|
|
||
| ################################################################################ |
Collaborator
Author
There was a problem hiding this comment.
@kkeene44 or @weiwangncar (who ever is more familiar with the Scala tests) I think it would be good for someone to spot-check this to make sure I have the equivalent logic being used in Scala tests to run the namelists.
The analogous info from large test matrix found in the Scala tests can be found in the .ci/wrf_em_real_tests.jsonc file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: testing, em_real
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
In the continued effort to port the regression tests to a usable format outside a single container environment, a generalized testing framework is now in place. However, this currently lacks the full set of tests.
Solution:
This implements a subset of the em_real tests, notably the tests that are stable, bitwise reproducible, and do not rely on in situ modification of configuration.
TESTS CONDUCTED: