Correct syntax with explicit function arguments where previously implicit #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgduda
requested changes
May 30, 2025
mgduda
approved these changes
May 30, 2025
amstokely
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: gcc, gcc15, compilation
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
GCC 15 uses newer standards compliance, notably the disallowance of
func()function declaration as a way to defer true arguments later specified in the function definition. Instead, functions declared asfunc()will be assumed to meanfunc(void)and any other amount of arguments must be explicitly noted in the declaration.Solution:
Make sure function declarations and definitions match.
ISSUE: For use when this PR closes an issue.
Fixes #2226
TESTS CONDUCTED:
RELEASE NOTE:
Fix compilation with GCC 15 by correcting function declaration syntax to explicitly list function arguments.