Fix wdpa id column name #692
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #692 +/- ##
========================================
Coverage 76.56% 76.56%
========================================
Files 143 143
Lines 6704 6704
========================================
Hits 5133 5133
Misses 1571 1571
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -288,7 +288,7 @@ async def get_wdpa_geostore_id(dataset, version, wdpa_id): | |||
| sql: Select = ( | |||
| db.select(columns_etc) | |||
| .select_from(src_table) | |||
| .where(db.text("wdpaid=:wdpa_id").bindparams(wdpa_id=wdpa_id)) | |||
| .where(db.text("wdpa_pid=:wdpa_id").bindparams(wdpa_id=wdpa_id)) | |||
There was a problem hiding this comment.
Just to be sure - you really mean wdpa_pid, here, rather that wdpa_id? Is wdpa_pid the name of the field in the database?
There was a problem hiding this comment.
Yes, it's wdpa_pid in the database -- i just surfaced it using what I think is user friendly wdpa_id
No description provided.