Conversation
The existing calculation was sometimes changing longitude 180 to -180 and vice versa. 180 and -180 are not equivalent, since a bounding box always takes the shortest direction around, which is different for 180 (or 179.9999) and -180 (or -179.9999). Change the calculation using to_4326() on cornerCoordinates (which is in meters) to existing wgs84Extent, which is already exactly in degrees. The resulting feature coordinates match the values from before the switch from using pixetl.
Gtc 3268/wdpa aoi dm
GTC-3276 Change calculation of extent metadata using wgs84Extent
fix geostore query; useful error with missing latest wdpa version
Fix wdpa id column name
solomon-negusse
approved these changes
May 5, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #693 +/- ##
==========================================
- Coverage 76.72% 76.56% -0.16%
==========================================
Files 143 143
Lines 6681 6704 +23
==========================================
+ Hits 5126 5133 +7
- Misses 1555 1571 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge develop to master. Includes: