Skip to content

Add documentation for union_bands and band_count creation options (for the online doc) #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2025

Conversation

danscales
Copy link
Collaborator

Add documentation for union_bands and band_count

Also, added descriptions for data_type and no_data.

I somewhat guessed on the meaning of band_count based on a few mentions in the code, so I definitely welcome comments on all of the descriptions, esp. union_bands and band_count.

jterry64 and others added 3 commits April 30, 2025 10:33
Merge develop to master
Also, added descriptions for data_type and no_data.
dmannarino
dmannarino previously approved these changes May 6, 2025
Copy link
Member

@dmannarino dmannarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.56%. Comparing base (7e3a1a8) to head (6f5aec9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #694   +/-   ##
========================================
  Coverage    76.56%   76.56%           
========================================
  Files          143      143           
  Lines         6704     6704           
========================================
  Hits          5133     5133           
  Misses        1571     1571           
Flag Coverage Δ
unittests 76.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

And adjusted wording in one other case.
@danscales danscales changed the base branch from master to develop May 8, 2025 14:52
@danscales danscales merged commit 8afe891 into develop May 8, 2025
2 checks passed
@danscales danscales deleted the doc_union_bands branch May 8, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants