Wri 489 social links #356

komejo · 2025-02-24T17:28:23Z

What issue(s) does this solve?

Too limited social media links, all displayed in different ways. Affects programs, projects, microsites, and profiles.

Issue Number:
https://github.com/wri/WRIN/issues/489

What is the new behavior?

Adds a 'Social Media sites' taxonomy, paragraph, and a paragraphs display field.
Layout builder default display in the body (except for 'person')

Profile requirements:

Does deploying this change require a change to config at the site level (choose one)?
- No config change is required.
- Yes, and I have written an update hooks to apply these config changes.
- Yes, and I've included updating instructions to be added to the release notes. The next release will need to be a major version increase. (Only do this in special cases.)

Site-level pull requests for testing. Only merge when these PRs are approved:

Create or update any site-level pull requests following the documentation

Flagship PR: https://github.com/wri/wriflagship/pull/1276

Checked on develop (TA to do)

Brasil
China
Indonesia

komejo · 2025-02-24T21:21:56Z

@mariacha This all installs perfectly on my local, but it seems to be having Circle issues - not sure how much of that is expected when there's Flagship and wri-sites things to be updated + 6 modules, four content types, etc.

mariacha

Ok @komejo this is really impressive! Sorry for the huge lift here.

I fixed the things that were causing the build to fail and added a lot of comments that are largely about the same things.

mariacha · 2025-02-25T17:40:15Z

...i_publication/config/install/core.entity_view_display.node.publication.hero_on_a_subpage.yml

@@ -1,3 +1,5 @@
+uuid: 83bf409b-e85b-4756-bd54-7b2f9ae15d88


Take off the uuid here please!

mariacha · 2025-02-25T18:05:45Z

...les/wri_person/config/install/core.entity_view_display.node.person.person_author_listing.yml

@@ -0,0 +1,135 @@
+langcode: en


It looks like this file is causing the problems with install. We are only using it on Flagship, which is why. You can just delete this and the install function that pulls it in. (I've done this)

mariacha · 2025-02-25T18:11:23Z

modules/wri_person/wri_person.install

+  \Drupal::service('distro_helper.updates')->installConfig('core.entity_view_display.node.person.person_author_listing', 'wri_person');
+  \Drupal::service('distro_helper.updates')->installConfig('core.entity_view_display.node.person.search_results', 'wri_person');
+  \Drupal::service('distro_helper.updates')->installConfig('core.entity_view_display.node.person.small_image_teaser', 'wri_person');
+  \Drupal::service('distro_helper.updates')->installConfig('core.entity_view_display.node.person.teaser', 'wri_person');


Since you're doing a more targetted update to the two display modes that matter below, you can skip everything but \Drupal::service('distro_helper.updates')->installConfig('field.field.node.person.field_paragraphs', 'wri_person'); here.

mariacha · 2025-02-25T18:34:22Z

...i_publication/config/install/core.entity_view_display.node.publication.hero_on_a_subpage.yml

@@ -26,6 +29,7 @@ dependencies:
    - field.field.node.publication.field_publication_series
    - field.field.node.publication.field_region
    - field.field.node.publication.field_related_resources
+    - field.field.node.publication.field_share_with_io


Since field_share_with_io is only in the Flagship site, I took this off here.

mariacha · 2025-02-25T18:48:08Z

...es/wri_project/config/install/core.entity_view_display.node.project_detail.superfeatured.yml

@@ -0,0 +1,207 @@
+langcode: en


This actually lives in web/profiles/contrib/wri_sites/modules/wri_superfeatured/config/install/core.entity_view_display.node.project_detail.superfeatured.yml already -- I moved it.

mariacha · 2025-02-25T19:48:50Z

modules/wri_program/wri_program.install

+ * Add field_paragraphs and update all view modes.
+ */
+function wri_program_update_10401() {
+  \Drupal::service('distro_helper.updates')->installConfig('field.field.node.program_center.field_paragraphs', 'wri_program');


And let's just leave the new field in here too.

mariacha · 2025-02-25T20:31:28Z

modules/wri_person/config/install/core.entity_form_display.node.person.default.yml

+      closed_mode_threshold: 0
+      add_mode: button
+      form_display_mode: default
+      default_paragraph_type: social_media_sites


Can you change these to default_paragraph_type: _none? Otherwise it's not clear that the social site isn't required (since fields within it are).

mariacha · 2025-02-25T20:46:29Z

...les/wri_project/config/install/core.entity_view_display.node.project_detail.main_content.yml

+      link: ''
+    third_party_settings: {  }
+    weight: 9
+    region: share


I wasn't very clear with my comment, but for Projects, we want the share links to appear at the bottom of the main_content region, under the body text. It can come out of the header and share sections entirely.

OK, I think I have this right, but it was behaving oddly trying to export / save the updated configs.

mariacha · 2025-02-25T20:53:22Z

modules/wri_project/config/install/core.entity_view_display.node.project_detail.full.yml

+            weight: 3
+            additional: {  }
+          -
+            uuid: c096c0b5-cccf-4994-94aa-99a39d69aec7


Since this is being pulled in on the main_content view mode, I don't think we need it here.

mariacha · 2025-02-25T20:54:48Z

...ri_project/config/install/core.entity_view_display.node.project_detail.hero_on_a_subpage.yml

    region: sidebar
+  field_paragraphs:


And this can come out of the share region on the hero on a subpage too.

komejo · 2025-02-26T16:57:46Z

@mariacha As I was doing the PR feedback I realized that at some point while adding the field, configs, and update hooks for the person, program, and project content types, I became confused and also added it to publications, which... why would a publication need it's own social site?? Unless there was something somewhere that asked for it and now I can't find it?

mariacha · 2025-02-26T17:09:51Z

@komejo No you're right -- publications don't need it! I missed that while going through this as well, but yeah, it's just Person, Program, Project and PMicrosite. :)

komejo · 2025-02-26T17:19:44Z

@mariacha OK, removing it was pretty easy - there shouldn't be any changes compared to main in web/profiles/contrib/wri_sites/modules/wri_publication now.

… don't show up.

mariacha

Ok, great -- this looks like it's in a pretty good place to me! I'll hold on merging until WRI can take a look, and either implement the feedback or pass back to you if I have any! I'm going to push up a couple of small changes first though.

komejo added 16 commits January 31, 2025 17:35

WRI 489: add social media vocab, field, display

7ff614e

WRI-489: add Social Media Sites paragraph

e9c6143

WRI-489: person, program, project, and pub configs

7ea6a84

WRI-489: field, form display, view modes

ccd2883

WRI-489: add explicit form display content import

aebc553

WRI-489: populate the Social Media vocabulary

9347bb1

WRI-489: post-update hook to migrate from twitter

4dcef5c

WRI-489: update display modes

ea2ac79

WRI-489: paragraph & taxonomy display modes, SASS

f42da39

WRI-489: theming, layouts, display mode updats

227a0bb

WRI-489: Layout Builder defaults

240ab94

WRI-489: Field and block overrides, theming

195e149

DCS

b5e8a8c

WRI-489: pull module dependency

6d2da81

WRI-489: more dependency tweaks

5357a2f

WRI-489: get the view_display working

2d4759f

komejo assigned mariacha Feb 24, 2025

komejo requested a review from mariacha February 24, 2025 21:15

Issue #489 fixing install config problems.

17d2c6f

mariacha requested changes Feb 25, 2025

View reviewed changes

WRI-489: PR feedback

e0283c0

komejo added 2 commits February 26, 2025 09:12

WRI-489: hide on subpage

5b7d629

WRI-489: publications do not need social media

2fbce3a

thinkshout-ci-bot added 2 commits February 26, 2025 12:20

Issue #489 adding some help text about the handle.

748b592

I think we also need to add the main_content region or the paragraphs…

ecd30cf

… don't show up.

mariacha approved these changes Feb 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wri 489 social links #356

Wri 489 social links #356

komejo commented Feb 24, 2025 •

edited

Loading

komejo commented Feb 24, 2025

mariacha left a comment

mariacha Feb 25, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

komejo Feb 26, 2025

mariacha Feb 25, 2025

mariacha Feb 25, 2025

komejo commented Feb 26, 2025

mariacha commented Feb 26, 2025 •

edited

Loading

komejo commented Feb 26, 2025

mariacha left a comment

Wri 489 social links #356

Are you sure you want to change the base?

Wri 489 social links #356

Conversation

komejo commented Feb 24, 2025 • edited Loading

What issue(s) does this solve?

What is the new behavior?

Profile requirements:

Site-level pull requests for testing. Only merge when these PRs are approved:

Checked on develop (TA to do)

komejo commented Feb 24, 2025

mariacha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

komejo commented Feb 26, 2025

mariacha commented Feb 26, 2025 • edited Loading

komejo commented Feb 26, 2025

mariacha left a comment

Choose a reason for hiding this comment

komejo commented Feb 24, 2025 •

edited

Loading

mariacha commented Feb 26, 2025 •

edited

Loading