Wri 347 filename update #359
Conversation
There was a problem hiding this comment.
This is generally working really well but I did find an bug on the node/add version of the media upload form.
I also appreciate the debugging messages but worry about them filling up the logs. Could you either comment them out or throw a flag around them so they only get logged if we've got debugging messages turned on? If you did a drush generate form:config in the wri_admin module with just one checkbox "Debug" it could do the trick.
| @@ -0,0 +1,13 @@ | |||
| description: | |||
There was a problem hiding this comment.
This file exists already once this comes in as a module. Can you try moving it to the config/install folder directly in the root? I think that will fix the error circle is throwing.
If it works, you can update the path in the update hook too (but you can leave it in the wri_admin module)
| @@ -99,3 +105,114 @@ function wri_admin_theme_suggestions_entity_moderation_form(array $variables) { | |||
|
|
|||
| return $suggestions; | |||
| } | |||
|
|
|||
| /** | |||
| * Validation function to ensure the media name is not just numbers. | |||
| \Drupal::logger('wri_admin')->notice('Form state keys: @keys', ['@keys' => implode(', ', $form_state_keys)]); | ||
|
|
||
| // Check if the 'name' field exists in the form state. | ||
| $name_values = $form_state->getValue('name'); |
There was a problem hiding this comment.
It looks like if you upload the file from a node page, the value is located within "Media" -- Try uploading a file named '1.jpg' as the hero image on an article.
What issue(s) does this solve?
Adds transliteration, prevents useless filenames such as 01_24.jpg.
What is the new behavior?
Warns about bad filenames, switched out bad names with a transliterated
namefield value.Profile requirements:
Site-level pull requests for testing. Only merge when these PRs are approved:
Create or update any site-level pull requests following the documentation
Checked on develop (TA to do)