Use multiprocessing to eliminate audio lag #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One problem I never got rid of when I renovated ZAutomate was the audio lag which happens intermittently or especially whenever the user performs a large search. I still hear the lag happen occasionally even during automation. What I know now that I didn't know then is that multithreading in Python isn't very effective because of the GIL, so Python provides the multiprocessing package to enable multi-threading but with separate processes instead of threads, which circumvents the GIL.
It's a simple fix but I can't test it myself as I don't have access to the studio anymore. @garrettdunc I see you're listed as the current computer engineer, if you could test my fixes in the studio when you get a chance and let me know if it works then we can get these fixes merged into the master branch.