Append sub-org ID to username when domain validation is disabled #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HasiniSama
force-pushed
the
email-domain-validation
branch
from
7d63e6a to
5d614ed
Compare
HasiniSama
force-pushed
the
email-domain-validation
branch
from
5d614ed to
9276ba2
Compare
sadilchamishka
approved these changes
Nov 12, 2024
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11793730980
...in/java/org/wso2/carbon/identity/application/authenticator/basicauth/BasicAuthenticator.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
&subject
Fixes: wso2/product-is#21504
This will also fix the flow for other tenants.
Goals
The current implementation of the basic authenticator skips the preprocessUsername method, which appends the sub-organization ID to the username. Without this appended ID, the userstore manager cannot locate the user in the correct organization. This causes the authentication status to be set as "FAIL", resulting in an authentication failure.
Approach
Move the preprocessUsername method call outside the if-condition.