Skip to content

Add password onboard executor #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

Add password onboard executor #223

merged 1 commit into from
Mar 6, 2025

Conversation

pamodaaw
Copy link
Contributor

@pamodaaw pamodaaw commented Mar 4, 2025 •
edited
Loading

Purpose

This PR introduces a registration executor to perform the password validation and enrollment into the profile of the user who is being registered.

Related issue: wso2/product-is#23356

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

ThaminduR
ThaminduR reviewed Mar 4, 2025
View reviewed changes
...va/org/wso2/carbon/identity/application/authenticator/basicauth/PasswordOnboardExecutor.java
response.setRequiredData(Collections.singletonList(PASSWORD));
return response;
} else {
// Todo enforce password policies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's track this with a git issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked with wso2/product-is#23373

@pamodaaw pamodaaw force-pushed the feature-reg-orch branch 2 times, most recently from 226ab10 to 4ea1b30 Compare March 4, 2025 06:51
ThaminduR
ThaminduR reviewed Mar 4, 2025
View reviewed changes
@pamodaaw pamodaaw force-pushed the feature-reg-orch branch 4 times, most recently from 3aea073 to 1eb32b8 Compare March 6, 2025 05:33
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13692117664

@pamodaaw pamodaaw merged commit 80462f7 into wso2-extensions:master Mar 6, 2025
1 check passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13692117664
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Mar 6, 2025
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13692117664

@ThaminduR ThaminduR mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaSK AnuradhaSK AnuradhaSK left review comments

@ThaminduR ThaminduR ThaminduR approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pamodaaw @jenkins-is-staging @AnuradhaSK @ThaminduR