Skip to content

Fix prompting active session handler for single sign on logins #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SujanSanjula96
Copy link
Contributor

@SujanSanjula96 SujanSanjula96 commented Mar 17, 2025

Purpose

Currently when a user has already created session in an application with an authenticator in the first step and when that same user tries to login to another application which has the previous authenticator + another authenticator + Active Session Limit Handler in authentication steps, it prompts for session termination UI when the max session limit is set to 1. In this kind of scenarios, new session is not created if we forget about the session limiter. So, if the login attempt is a single sign on attempt, ideally session termination prompt should not be prompted. With this PR, if the login attempt is a single sign on attempt, it will be not considered for active session limit.

Related Issue - wso2/product-is#23391

This is also been addressed with #224 PR, but we need to consider the scenario of using session id based SSO scenario.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.23%. Comparing base (063b25c) to head (635524b).
Report is 24 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
+ Coverage     39.21%   39.23%   +0.02%     
  Complexity      209      209              
============================================
  Files            25       25              
  Lines          1785     1784       -1     
  Branches        316      315       -1     
============================================
  Hits            700      700              
+ Misses          964      963       -1     
  Partials        121      121              
Flag Coverage Δ
unit 43.14% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/14027877010

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/14027877010
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/14027877010

@SujanSanjula96
Copy link
Contributor Author

Since test module is not available for this component, we need to add unit tests to cover considerable amount of code in addition to the unit tests for this scenario. Will add the unit tests with a separate PR.

@SujanSanjula96 SujanSanjula96 merged commit a46d3a0 into wso2-extensions:master Mar 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants