-
Notifications
You must be signed in to change notification settings - Fork 141
Fix prompting active session handler for single sign on logins #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prompting active session handler for single sign on logins #227
Conversation
51f479c
to
548e0a5
Compare
...2/carbon/identity/application/authentication/handler/session/ActiveSessionsLimitHandler.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
============================================
+ Coverage 39.21% 39.23% +0.02%
Complexity 209 209
============================================
Files 25 25
Lines 1785 1784 -1
Branches 316 315 -1
============================================
Hits 700 700
+ Misses 964 963 -1
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/14027877010
Since test module is not available for this component, we need to add unit tests to cover considerable amount of code in addition to the unit tests for this scenario. Will add the unit tests with a separate PR. |
Purpose
Related Issue - wso2/product-is#23391
This is also been addressed with #224 PR, but we need to consider the scenario of using session id based SSO scenario.