Skip to content

Set IS_USER_RESOLVED property when ValidateUsername is enabled from adaptive script #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented May 27, 2025

In the Identifier First, when the ValidateUsername is configured as authenticator config, the user is resolved and the isUserResolved flag is correctly set in the authentication context. However, when ValidateUsername is set via an adaptive authentication script parameter, the user is still resolved, but isUserResolved is not set in the context.

This PR ensures that isUserResolved is correctly set in the context even when ValidateUsername is enabled through the adaptive authentication script.

Refer:

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.56%. Comparing base (635524b) to head (9600618).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
...tication/handler/identifier/IdentifierHandler.java 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
+ Coverage     39.23%   39.56%   +0.33%     
+ Complexity      209      207       -2     
============================================
  Files            25       25              
  Lines          1784     1759      -25     
  Branches        315      313       -2     
============================================
- Hits            700      696       -4     
+ Misses          963      943      -20     
+ Partials        121      120       -1     
Flag Coverage Δ
unit 43.12% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/15282358395

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/15282358395
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/15282358395

@PasinduYeshan PasinduYeshan merged commit 4eb7ff2 into wso2-extensions:master May 29, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants