Tooltip doesn't show Visible to my domain

[sccalabr]

Issue: wso2/api-manager#3438 (comment)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sccalabr
❌ totesforlife
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[tharikaGitHub]

The word current tenant domain might not be intuitive. Shall we use similar wording in our official documentation for this option?

[sccalabr]

Let me know if that is what you were thinking

[tharikaGitHub]

Hi @sccalabr, Thank you for working on the requested changes. I applied your fix locally and the issue is fixed. During the application of the fix, several EsLint related issues were encountered. Shall we run an npm run build:prod build and verify EsLint issues and correct them?

[tharikaGitHub]

Hi @sccalabr, any update on the above?

[sccalabr]

I'I'll get to it on the weekend :)

[tharikaGitHub]

We will not need changes done to this file @sccalabr.

[tharikaGitHub]

Shall we keep line 616 and 617 only, which contains your changes and remove the rest of the changes?

[tharikaGitHub]

Hi @sccalabr did you get a chance to address the new review comments?

[sccalabr]

That's the output from running the command. I think we should keep it do the whole file is formatted correctly

[tharikaGitHub]

Hi @sccalabr,

After building the apim-apps repository using the mvn clean install command with node version v22.x, I do not see any changes applied to package-lock.json file and also the en.json does not contain changes apart from the new ids relevant to your fix. What are the steps you followed to build the repo?

And also your changes in the file StoreVisibility.jsx do not compile correctly as they exceed the 120 character length.

Shall we fix this?

[sccalabr]

I ran npm run build:prod

[tharikaGitHub]

Hi @sccalabr

Okay. Can you try with mvn clean install after removing the changes from files en.json and package-lock.json? Remember to fetch the latest changes from upstream main branch before building using mvn clean install. You can see that our automated repo build has also failed with the changes in this PR. So shall we correct it and update the PR? I will be able to approve the PR after that because the changes you have done to the StoreVisibility.jsx file are correct.

Thanks,
Tharika.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tharikaGitHub]

Hi @sccalabr Thank you for addressing the comments. Shall we fetch from upstream repo and try building again with mvn clean install as mentioned in comment [1] because I see there are unrelated changes in the en.json file in the PR. Make sure to fetch the latest changes.

[1] #1169 (comment)