Improvements to create and publish api product error handling

[Milanka00]

Purpose

Following is the current behaviour of create & publish API product.

1. For errors,

• In the flow, createAndPublishAPIProduct invokes createAPIProduct()
• .catch() inside createAPIProduct handles the error but does not rethrow it
• Therefore .then() in createAndPublishAPIProduct still gets called
• This results in alerting unwanted success alert and state issues in button as it set setIsRevisioning(true)

2. For sucess,

• Duplicate product creation success alerts are coming as both createAndPublishAPIProduct and createAPIProduct() have defined them

Approach

• Let createAPIProduct() throw the errors so that both createAndPublishAPIProduct and createAPIProductOnly can handle them
• Remove duplicate success alert from createAndPublishAPIProduct
• Make the state changes at right place

Fixes wso2/api-manager/issues/4461

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud