Skip to content

fix: Fix UI issues in rate limiting Resources page #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −6
Open

fix: Fix UI issues in rate limiting Resources page #1204

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7af9ed3
fix: Fix UI issues in rate limiting Resources page
Ratheshan03 Oct 27, 2025
d28ff7f
Remove en.json changes
Ratheshan03 Oct 30, 2025
7a5b520
Fix button alignment more precisly
Ratheshan03 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .../components/Apis/Details/Resources/components/operationComponents/OperationGovernance.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export default function OperationGovernance(props) {
<Grid item md={1} />
<Grid item md={5}>
{componentValidator.includes('operationLevelRateLimiting') &&
<Box display='flex' flexDirection='row' alignItems='flex-start'>
<Box display='flex' flexDirection='row' alignItems='center'>
<TextField
select
fullWidth={!isOperationRateLimiting}
Expand All @@ -161,9 +161,7 @@ export default function OperationGovernance(props) {
<Box
fontWeight='fontWeightBold'
display='inline'
color='primary.main'
cursor='pointer'
sx ={{ marginLeft: '4px' }}
sx={{ marginLeft: '4px' }}
>
<FormattedMessage
id={'Apis.Details.Resources.components.operationComponents.'
Expand Down Expand Up @@ -199,7 +197,7 @@ export default function OperationGovernance(props) {
defaultMessage='Use'
/>
{' '}
<Box fontWeight='fontWeightBold' display='inline' color='primary.main'>
<Box fontWeight='fontWeightBold' display='inline'>
<FormattedMessage
id={'Apis.Details.Resources.components.operationComponents.'
+ 'OperationGovernance.rate.limiting.helperText.section2'}
Expand Down Expand Up @@ -244,7 +242,17 @@ export default function OperationGovernance(props) {
))}
</TextField>
{!isOperationRateLimiting && (
<Button onClick={scrollToTop}>
<Button
Copy link
Member

@tharikaGitHub tharikaGitHub Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ratheshan03 Regarding this change, I have applied your fix locally and observed the behaviour. The button has gone a little down and the alignment looks a bit off from the bottom level compared with the input box. And also clicking on the button does not scroll to the top with the fix still. Will it be possible to check and fix?

Screenshot 2025-10-30 at 11 21 48

Copy link
Author

@Ratheshan03 Ratheshan03 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tharikaGitHub, Made the changes that you requested above, now the alignement is fixed more precisly and the functionality of the button is already seemed working and i also verified its working and scrolls to thte top. the evidence to the testing has been given below:

issue-4338-fix
Publisher.-.WSO2.APIM.-.Google.Chrome.2025-10-30.14-27-46.mp4

Thanks.

onClick={scrollToTop}
variant='text'
size='small'
sx={{
ml: 1,
mb: 1,
textTransform: 'none',
minWidth: 'auto'
}}
>
<FormattedMessage
id={
'Apis.Details.Resources.components.operationComponents.'
Expand Down
Loading