Skip to content

Conversation

@ranuka-laksika
Copy link

Fixes issue #3724 - Multiple UI issues related to GraphQL APIs

Issue URL: wso2/api-manager#3724

Changes Made

  • Fixed the dropdown disabling logic for GraphQL API rate limiting in Operations page
  • Changed isOperationRateLimiting={!apiThrottlingPolicy} to isOperationRateLimiting={apiThrottlingPolicy === null}
  • This ensures that operation-level dropdowns are properly disabled when API-level rate limiting is selected

Problem Description

When changing from operation level to API level rate limiting for a GraphQL API, operation level rate limiting selection dropdowns were not being disabled immediately. The issue occurred because:

  1. When API-level is selected, apiThrottlingPolicy is initially set to empty string ('')
  2. The logic was using !apiThrottlingPolicy which evaluates to true for empty string
  3. This kept operation dropdowns enabled until a policy was actually selected

Solution

The fix changes the condition to explicitly check for null value, which correctly identifies when operation-level rate limiting should be disabled.

Build Information

  • Built using Java 11 and Maven 3.6.3
  • Generated artifacts: publisher.war
  • Location: portals/publisher/target/publisher.war

Artifact Replacement

  • Replaced publisher folder in wso2am-4.6.0 pack
  • Location: wso2am-4.6.0/repository/deployment/server/webapps/publisher

Modified wso2am-4.6.0 Pack (GitHub Actions Artifact)

The complete modified wso2am-4.6.0 pack with all updated artifacts has been uploaded as a GitHub Actions artifact.

Download Link:
🔗 Download from GitHub Actions Run

Artifact Details:

  • Artifact Name: wso2am-4.6.0-issue-30.zip
  • Location: Available in the GitHub Actions workflow run linked above
  • How to Download:
    1. Click the GitHub Actions run link above
    2. Scroll down to the "Artifacts" section at the bottom of the page
    3. Download the artifact: wso2am-4.6.0-issue-30.zip
    4. Extract and use the modified pack directly

What's included:

  • Updated publisher.war with the fix for GraphQL API rate limiting dropdown logic
  • Complete wso2am-4.6.0 directory structure
  • Ready to use without any additional build steps

Testing

No testing required for frontend repository changes as per workflow guidelines.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant